Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the strings and colors in the proposals answers states #121

Merged
merged 9 commits into from
Dec 18, 2023

Conversation

andreslucena
Copy link
Member

For the Metadecidim feature proposals process, we need to change some of
the words that use in the answers:

  • "Accepted" becomes "Finished"
  • "Evaluating" becomes "Accepted / In progress"

We also need to change the colors for these labels:

  • The "warning" label changes to green
  • The "success" label changes to purple

Screenshots

Screenshot of the proposals frontend with the changes

Screenshot of the proposals backend (aka admin) with the changes

Screenshot of the notifications emails

Testing

  • Create proposals with different statuses and see that these changes are applied
  • Change the languages to the ones supported on meta.decidim.org (Spanish and Catalan) and see that these strings are also changed

For the Metadecidim feature proposals process, we need to change some of
the words that use in the answers:

- "Accepted" becomes "Finished"
- "Evaluating" becomes "Accepted / In progress"
- The "warning" label changes to green
- The "success" label changes to purple
@andreslucena
Copy link
Member Author

Maybe the CSS changes we need to do them with a Javascript hack (i.e. checking that the URL is inside this particular process?) as the CSS change could be applied to other labels. I'm not so sure actually.

@andreslucena andreslucena changed the title Change the strings in the proposals answers states Change the strings and colors in the proposals answers states Dec 14, 2023
@andreslucena andreslucena marked this pull request as draft December 14, 2023 07:09
@andreslucena andreslucena marked this pull request as ready for review December 14, 2023 11:05
Copy link
Contributor

@alecslupu alecslupu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

image

@fblupi fblupi merged commit c19d6ab into master Dec 18, 2023
1 check passed
@fblupi fblupi deleted the feature/answers-customization branch December 18, 2023 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants